Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement OnyxForm with disabled state injection #1902

Merged
merged 28 commits into from
Oct 2, 2024
Merged

feat: Implement OnyxForm with disabled state injection #1902

merged 28 commits into from
Oct 2, 2024

Conversation

JoCa96
Copy link
Collaborator

@JoCa96 JoCa96 commented Sep 30, 2024 •
edited
Loading

Relates to #757

  • Implement OnyxForm component: Wrapper around Form, which allows setting the disabled state for all child form elements
  • Add E2E and unit tests
  • Add Storybook Documentation
  • Update all form elements to use injected disabled state

@JoCa96 JoCa96 requested a review from a team as a code owner September 30, 2024 16:38
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: cee3b9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
sit-onyx Minor
@sit-onyx/storybook-utils Major
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoCa96 JoCa96 changed the title feat: Implement OnyxForm feat: Implement OnyxForm with disabled state injection Oct 1, 2024
larsrickert
larsrickert requested changes Oct 1, 2024
View reviewed changes
packages/sit-onyx/src/components/OnyxForm/OnyxForm.core.ts Outdated Show resolved Hide resolved
packages/sit-onyx/src/components/OnyxForm/OnyxForm.core.ts Outdated Show resolved Hide resolved
packages/sit-onyx/src/components/OnyxForm/OnyxForm.stories.ts Outdated Show resolved Hide resolved
packages/sit-onyx/src/components/OnyxForm/OnyxForm.stories.ts Show resolved Hide resolved
packages/sit-onyx/src/components/OnyxForm/OnyxForm.vue Outdated Show resolved Hide resolved
packages/sit-onyx/src/components/OnyxForm/OnyxForm.core.ts Show resolved Hide resolved
packages/sit-onyx/src/components/OnyxSelect/types.ts Outdated Show resolved Hide resolved
packages/sit-onyx/src/components/OnyxSelectInput/OnyxSelectInput.vue Outdated Show resolved Hide resolved
packages/sit-onyx/.storybook/formInjected.ts Outdated Show resolved Hide resolved
packages/sit-onyx/src/components/OnyxForm/OnyxForm.stories.ts Show resolved Hide resolved
@larsrickert larsrickert self-assigned this Oct 1, 2024
larsrickert
larsrickert previously approved these changes Oct 1, 2024
View reviewed changes
@JoCa96 JoCa96 dismissed larsrickert’s stale review October 1, 2024 14:57

The merge-base changed after approval.

@JoCa96 JoCa96 enabled auto-merge (squash) October 2, 2024 06:40
@JoCa96 JoCa96 merged commit 5d8349c into main Oct 2, 2024
19 checks passed
@JoCa96 JoCa96 deleted the 757-onyx-form branch October 2, 2024 06:52
@larsrickert larsrickert mentioned this pull request Oct 8, 2024
Merged
1 task
larsrickert added a commit that referenced this pull request Oct 11, 2024
@larsrickert
fix(OnyxButton): ripple animation not working (#1933)
a9d89f6 
closes #1934
Issue caused by #1902 

Fix OnyxButton to show ripple animation again on click.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsrickert larsrickert larsrickert approved these changes

Assignees

@larsrickert larsrickert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoCa96 @larsrickert